feat: GDrive File Scope implementation with file picker #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will serve to replace the GenClientId process by using commandLine args to pass values to be inlined into the plugin
This allows us to grant access to specific files to our application, instead of granting global access. That'll help us get around both the google blocking issue, and the kdbx file duplication issue when using limited file scope The UI elements wrapping around this will be added in a later commit
This PR adds a UI element that displays a cancellation button, and calls the file picker service. This will allows us to add a button in the plugin config that makes this form show up and redirect the user to their browser
Since we've already implemented a new process to read some configuration items from build params, we no longer need the T4 generation to build the clientId into the app
This flow will allow us to build and upload our artifacts whenever we cut a new release. It also lays the groundwork for simplifying how we manage autoupdate files
This will allow the plugin to be built from any repo without code changes, and allows us to have the auto-update file in our release artifacts instead of the repo
retlok
approved these changes
Dec 14, 2024
Would we need to change these if we were to use your compiled plugin ? Hoping this PR gets implemented since my entire workflow using this plugin and keepass has suffered since the google changes. Thank you @desmaraisp for working on this ❤️ |
Only if you want to build the plugin yourself (ie when this is merged, we'll need to add the values to the repo's vars). People installing the plugin shouldn't need to touch that at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements #51, which aimed to fix #79. With this PR, the plugin uses the file scope only, avoiding the "Google blocked this access issue", without requiring any App Review from Google. It also adds a new button in the plugin config that serves to grant access to existing files in the gDrive so that we can avoid creating duplicate files when syncing across multiple devices
You can find a compiled release of the plugin here: KPSyncForDrive-5.0.0.zip, using my own ClientId, certificate and AutoUpdate Url